Bug 133686

Summary: REGRESSION (r169725): Several TextTrackCue tests became very flaky
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: NEW    
Severity: Normal CC: aestes, bfulgham, buildbot, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, rniwa, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=142484
Attachments:
Description Flags
Proposed patch.
simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 none

Alexey Proskuryakov
Reported 2014-06-10 11:24:09 PDT
Multiple TextTrackCue tests have started to fail frequently on all Mac bots yesterday: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Fw3c%2Finterfaces%2FTextTrackCue%2FendTime.html media/track/w3c/interfaces/TextTrackCue/align.html media/track/w3c/interfaces/TextTrackCue/endTime.html media/track/w3c/interfaces/TextTrackCue/id.html media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html media/track/w3c/interfaces/TextTrackCue/startTime.html media/track/w3c/interfaces/TextTrackCue/track.html
Attachments
Proposed patch. (2.39 KB, patch)
2014-06-12 08:50 PDT, Eric Carlson 		simon.fraser: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (508.05 KB, application/zip)
2014-06-12 10:17 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (509.47 KB, application/zip)
2014-06-12 11:24 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (533.73 KB, application/zip)
2014-06-12 14:58 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2014-06-10 14:37:36 PDT
Skipped in r169767: http://trac.webkit.org/changeset/169767
Andy Estes
Comment 2 2014-06-10 14:57:45 PDT
Changed from [ Skip ] to [ Pass Failure ] in r169771: http://trac.webkit.org/changeset/169771
Simon Fraser (smfr)
Comment 3 2014-06-10 16:07:47 PDT
When they fail the TextTrack mode is "disabled".
Simon Fraser (smfr)
Comment 4 2014-06-10 16:09:00 PDT
Mode is set to disabled via: * thread #1: tid = 0xe6efb, 0x0000000105d13097 WebCore`WebCore::TextTrack::setMode(this=0x000000010ff2d390, mode=0x0000000117703270) + 23 at TextTrack.cpp:213, queue = 'com.apple.main-thread', stop reason = breakpoint 10.1 * frame #0: 0x0000000105d13097 WebCore`WebCore::TextTrack::setMode(this=0x000000010ff2d390, mode=0x0000000117703270) + 23 at TextTrack.cpp:213 frame #1: 0x000000010498f173 WebCore`WebCore::HTMLMediaElement::configureTextTrackGroup(this=0x0000000113833200, group=0x00007fff5fbfce90) + 2275 at HTMLMediaElement.cpp:3634 frame #2: 0x00000001049819fb WebCore`WebCore::HTMLMediaElement::configureTextTracks(this=0x0000000113833200) + 1307 at HTMLMediaElement.cpp:3795 frame #3: 0x000000010497da93 WebCore`WebCore::HTMLMediaElement::loadTimerFired(this=0x0000000113833200, =0x00000001138332c0) + 99 at HTMLMediaElement.cpp:799
Brent Fulgham
Comment 5 2014-06-10 16:27:55 PDT
The system is determining that the tracks in the test are not a close enough match to the user's caption preferences, and is turning them all off. 1. DRT/WKTR should probably override these preferences. 2. The step to make the track "display" may need to happen in the onload handler, since it seems like that is firing before the property is being set.
Simon Fraser (smfr)
Comment 6 2014-06-10 17:19:34 PDT
In DRT, CaptionUserPreferencesMediaAF::captionDisplayMode() is testing testingMode(), which is true in DRT, so captionDisplayMode() returns ForcedOnly. In MiniBrowser, it returns Automatic.
Simon Fraser (smfr)
Comment 7 2014-06-10 17:29:26 PDT
Eric, this regressed with r169725. Please take a look.
Eric Carlson
Comment 8 2014-06-12 08:50:39 PDT
Created attachment 232954 [details] Proposed patch.
Simon Fraser (smfr)
Comment 9 2014-06-12 09:10:37 PDT
Comment on attachment 232954 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=232954&action=review > Source/WebCore/html/HTMLMediaElement.cpp:1580 > + LOG(Media, "HTMLMediaElement::textTrackModeChanged - mode = %s", String(track->mode()).utf8().data()); It would have been helpful when debugging this if logging had included data on which track was being logged; either the value of |this| or some kind of track ID.
Alexey Proskuryakov
Comment 10 2014-06-12 09:15:00 PDT
Comment on attachment 232954 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=232954&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Please remove the tests from TestExpectations.
Build Bot
Comment 11 2014-06-12 10:17:46 PDT
Comment on attachment 232954 [details] Proposed patch. Attachment 232954 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4652199305019392 New failing tests: media/video-trackmenu-selection.html
Build Bot
Comment 12 2014-06-12 10:17:53 PDT
Created attachment 232961 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 13 2014-06-12 11:24:49 PDT
Comment on attachment 232954 [details] Proposed patch. Attachment 232954 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4661729837449216 New failing tests: media/video-trackmenu-selection.html
Build Bot
Comment 14 2014-06-12 11:24:59 PDT
Created attachment 232968 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 15 2014-06-12 14:57:54 PDT
Comment on attachment 232954 [details] Proposed patch. Attachment 232954 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6058470381977600 New failing tests: media/video-trackmenu-selection.html
Build Bot
Comment 16 2014-06-12 14:58:02 PDT
Created attachment 232993 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Simon Fraser (smfr)
Comment 17 2014-06-12 19:50:13 PDT
Looks like this breaks media/video-trackmenu-selection.html. What's the plan?
Alexey Proskuryakov
Comment 18 2014-07-17 10:06:18 PDT
Ping?
Alexey Proskuryakov
Comment 19 2016-03-16 12:03:28 PDT
Is this patch still relevant?
Note You need to log in before you can comment on or make changes to this bug.