Bug 134842

Summary: [CSS Grid Layout] Remove stack from grid-auto-flow syntax
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, svillar, syoichi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 134544    
Bug Blocks: 103316    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing (adding reviewer) none

Manuel Rego Casasnovas
Reported 2014-07-11 13:44:00 PDT
Once the new grid-auto-flow syntax is ready (bug #134057) we should implement proper support for stack mode in auto-placement algorithm.
Attachments
Patch (63.18 KB, patch)
2014-12-26 07:13 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch for landing (63.54 KB, patch)
2015-01-02 01:17 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch for landing (adding reviewer) (63.55 KB, patch)
2015-01-02 01:19 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2014-12-26 07:02:04 PST
After some discussion in the CSS WG, in the last update of the spec "stack" mode has been dropped: http://dev.w3.org/csswg/css-grid/#propdef-grid-auto-flow We need to update the syntax again to remove "stack" option and also remove the pending FIXMEs from the source code.
Manuel Rego Casasnovas
Comment 2 2014-12-26 07:13:14 PST
Created attachment 243760 [details] Patch
Sergio Villar Senin
Comment 3 2015-01-02 01:11:20 PST
Comment on attachment 243760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243760&action=review Nice! I never understood the purpose of stack actually. > Source/WebCore/rendering/style/GridResolvedPosition.cpp:141 > } Nit: we can move the comment above the if and remove the curly braces.
Manuel Rego Casasnovas
Comment 4 2015-01-02 01:17:23 PST
Created attachment 243883 [details] Patch for landing
Manuel Rego Casasnovas
Comment 5 2015-01-02 01:19:37 PST
Created attachment 243884 [details] Patch for landing (adding reviewer)
WebKit Commit Bot
Comment 6 2015-01-02 02:01:14 PST
Comment on attachment 243884 [details] Patch for landing (adding reviewer) Clearing flags on attachment: 243884 Committed r177858: <http://trac.webkit.org/changeset/177858>
WebKit Commit Bot
Comment 7 2015-01-02 02:01:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.