Bug 137428

Summary:

Render alt attribute value when images are blocked

Product:

WebKit

Reporter:

Takeshi Kurosawa <taken.spc>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ap, buildbot, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none

Takeshi Kurosawa

Reported 2014-10-04 21:36:21 PDT

Render alt attribute value when images are blocked

Attachments
Patch (4.91 KB, patch) 2014-10-04 21:41 PDT, Takeshi Kurosawa	ap: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (630.20 KB, application/zip) 2014-10-04 23:08 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (1.21 MB, application/zip) 2014-10-05 00:00 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Takeshi Kurosawa

Comment 1 2014-10-04 21:41:22 PDT

Created attachment 239290 [details] Patch

WebKit Commit Bot

Comment 2 2014-10-04 21:44:13 PDT

Attachment 239290 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:12: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2014-10-04 23:08:00 PDT

Comment on attachment 239290 [details] Patch Attachment 239290 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6251265063387136 New failing tests: fast/forms/basic-buttons.html

Build Bot

Comment 4 2014-10-04 23:08:04 PDT

Created attachment 239294 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2014-10-05 00:00:00 PDT

Comment on attachment 239290 [details] Patch Attachment 239290 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5028049787551744 New failing tests: fast/forms/basic-buttons.html

Build Bot

Comment 6 2014-10-05 00:00:04 PDT

Created attachment 239296 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Alexey Proskuryakov

Comment 7 2014-10-06 10:01:30 PDT

Comment on attachment 239290 [details] Patch A WebKit fix like this must come with a regression test. Also, this patch breaks an existing test.

Alexey Proskuryakov

Comment 8 2014-10-06 10:02:28 PDT

Please see discussion in bug 5566 and in related bugs (such as bug 17967). *** This bug has been marked as a duplicate of bug 5566 ***

Note You need to log in before you can comment on or make changes to this bug.