Bug 171188

Summary: [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Attachments
Patch (7.59 KB, patch)
2017-04-27 09:26 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
Patch (7.54 KB, patch)
2017-04-28 09:52 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-04-22 21:10:38 PDT
<rdar://problem/31776306>
Joanmarie Diggs
Comment 2 2017-04-27 09:26:25 PDT
Created attachment 308399 [details] Patch
Joanmarie Diggs
Comment 3 2017-04-28 09:03:59 PDT
Chris: Please review. Thanks!
chris fleizach
Comment 4 2017-04-28 09:08:55 PDT
Comment on attachment 308399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308399&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:2029 > + Node* node = this->node(); this node check doesn't seem necessary > Source/WebCore/accessibility/AccessibilityObject.cpp:2033 > + AXObjectCache* cache = axObjectCache(); if (AXObjectCache* cache = axObjectCache()) return cache->ariaModalNode() == node(); return false;
Joanmarie Diggs
Comment 5 2017-04-28 09:43:44 PDT
(In reply to chris fleizach from comment #4) > Comment on attachment 308399 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308399&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:2029 > > + Node* node = this->node(); > > this node check doesn't seem necessary What if we created an AccessibilityObject which lacked a node, and didn't have any nodes with aria-modal="true"? > > Source/WebCore/accessibility/AccessibilityObject.cpp:2033 > > + AXObjectCache* cache = axObjectCache(); > > if (AXObjectCache* cache = axObjectCache()) > return cache->ariaModalNode() == node(); > > return false;
chris fleizach
Comment 6 2017-04-28 09:45:54 PDT
(In reply to Joanmarie Diggs (irc: joanie) from comment #5) > (In reply to chris fleizach from comment #4) > > Comment on attachment 308399 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=308399&action=review > > > > > Source/WebCore/accessibility/AccessibilityObject.cpp:2029 > > > + Node* node = this->node(); > > > > this node check doesn't seem necessary > > What if we created an AccessibilityObject which lacked a node, and didn't > have any nodes with aria-modal="true"? hmm yea that would be true if (AXObjectCache* cache = axObjectCache()) return node() && cache->ariaModalNode() == node(); > > > > Source/WebCore/accessibility/AccessibilityObject.cpp:2033 > > > + AXObjectCache* cache = axObjectCache(); > > > > if (AXObjectCache* cache = axObjectCache()) > > return cache->ariaModalNode() == node(); > > > > return false;
Joanmarie Diggs
Comment 7 2017-04-28 09:52:52 PDT
Created attachment 308543 [details] Patch
WebKit Commit Bot
Comment 8 2017-04-28 10:47:29 PDT
The commit-queue encountered the following flaky tests while processing attachment 308543 [details]: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2017-04-28 10:47:30 PDT
The commit-queue encountered the following flaky tests while processing attachment 308543 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2017-04-28 11:17:30 PDT
Comment on attachment 308543 [details] Patch Clearing flags on attachment: 308543 Committed r215932: <http://trac.webkit.org/changeset/215932>
WebKit Commit Bot
Comment 11 2017-04-28 11:17:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.