Bug 172196

Created attachment 310347 [details] Patch

Comment on attachment 310347 [details] Patch Attachment 310347 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3757127 New failing tests: imported/w3c/web-platform-tests/notifications/event-onclose.html

Created attachment 310350 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 310347 [details] Patch Attachment 310347 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3761930 New failing tests: imported/w3c/web-platform-tests/notifications/event-onclose.html

Created attachment 310381 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 310347 [details] Patch r=me as long as the bots are happy. View in context: https://bugs.webkit.org/attachment.cgi?id=310347&action=review > LayoutTests/resources/testharnessreport.js:18 > + testRunner.grantWebNotificationPermission(document.origin); I guess that ideally we should do that conditionally on the widow.location, so that it only applies to WPT and not other layout tests. But maybe this is good enough like this. We might want to do the same for getUserMedia permission then. It seems a bit different from the other testRunner calls, so maybe there should be some comments or a line separation here.

(In reply to Build Bot from comment #5) > Created attachment 310381 [details] > Archive of layout-test-results from ews103 for mac-elcapitan > > The attached test failures were seen while running run-webkit-tests on the > mac-ews. > Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6 Well, the failure is strange and WK1 only: --- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/retries/imported/w3c/web-platform-tests/notifications/event-onclose-expected.txt +++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/retries/imported/w3c/web-platform-tests/notifications/event-onclose-actual.txt @@ -1,4 +1,5 @@ - -PASS Checked test prerequisites. -PASS Invoked the onclose event handler. - +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x600 + RenderBlock {HTML} at (0,0) size 800x600 + RenderBody {BODY} at (8,8) size 784x584

Created attachment 310396 [details] Patch

The commit-queue encountered the following flaky tests while processing attachment 310396 [details]: http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org) The commit-queue is continuing to process your patch.

The commit-queue encountered the following flaky tests while processing attachment 310396 [details]: The commit-queue is continuing to process your patch.

Comment on attachment 310396 [details] Patch Rejecting attachment 310396 [details] from commit-queue. New failing tests: http/tests/appcache/404-resource-with-slow-main-resource.php Full output: http://webkit-queues.webkit.org/results/3763421

Created attachment 310404 [details] Archive of layout-test-results from webkit-cq-03 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 310396 [details] Patch Clearing flags on attachment: 310396 Committed r216979: <http://trac.webkit.org/changeset/216979>

All reviewed patches have been landed. Closing bug.