Bug 172493

Summary: [css-grid] Ignore collapsed tracks on content-distribution alignment
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: BlinkMergeCandidate, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=707633
Bug Depends on: 172494    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2017-05-23 01:34:47 PDT
The spec has been recently updated as you can see in the following discussion: https://github.com/w3c/csswg-drafts/issues/1140 The main issue here is that we shouldn't take into account the collapsed tracks for gutters when we do the Content Distribution. This has been already fixed in Blink: https://codereview.chromium.org/2825133003
Attachments
Patch (8.69 KB, patch)
2017-05-23 15:08 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2017-05-23 15:08:01 PDT
Created attachment 311060 [details] Patch
WebKit Commit Bot
Comment 2 2017-05-24 01:35:05 PDT
Comment on attachment 311060 [details] Patch Clearing flags on attachment: 311060 Committed r217345: <http://trac.webkit.org/changeset/217345>
WebKit Commit Bot
Comment 3 2017-05-24 01:35:07 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-05-30 20:24:20 PDT
<rdar://problem/32479781>
Note You need to log in before you can comment on or make changes to this bug.