Bug 174758

Summary: [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, megan_gardner, mitz, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mitz: review+
Patch for landing none

Wenson Hsieh
Reported 2017-07-22 20:10:55 PDT
_WKDraggableElementInfo is no longer used anywhere in WebKit, so it should be removed. However, some edge cases in PositionInformationTests that currently use _WKDraggableElementInfo are still useful tests to keep around, so fold them into the WKRequestActivatedElementInfo test suite.
Attachments
Patch (37.26 KB, patch)
2017-07-22 20:45 PDT, Wenson Hsieh 		mitz: review+
DetailsFormatted DiffDiff
Patch for landing (37.26 KB, patch)
2017-07-22 21:50 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-07-22 20:45:21 PDT
Created attachment 316222 [details] Patch
mitz
Comment 2 2017-07-22 21:01:42 PDT
Comment on attachment 316222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316222&action=review > Tools/TestWebKitAPI/cocoa/TestWKWebView.h:56 > +- (_WKActivatedElementInfo *)_activatedElementAtPosition:(CGPoint)position; Probably don’t need the underscore prefix on this method’s name. It’s like the rest of the TestWKWebView methods.
Wenson Hsieh
Comment 3 2017-07-22 21:43:05 PDT
(In reply to mitz from comment #2) > Comment on attachment 316222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316222&action=review > > > Tools/TestWebKitAPI/cocoa/TestWKWebView.h:56 > > +- (_WKActivatedElementInfo *)_activatedElementAtPosition:(CGPoint)position; > > Probably don’t need the underscore prefix on this method’s name. It’s like > the rest of the TestWKWebView methods. Good catch -- fixed. I originally had it as SPI on WKWebView, and then decided to move it into TestWebKitAPI but didn't rename it. Thanks for the review!
Wenson Hsieh
Comment 4 2017-07-22 21:50:58 PDT
Created attachment 316224 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-07-22 22:28:37 PDT
Comment on attachment 316224 [details] Patch for landing Clearing flags on attachment: 316224 Committed r219768: <http://trac.webkit.org/changeset/219768>
Note You need to log in before you can comment on or make changes to this bug.