Bug 177550

Summary: [GStreamer] Try to play AVC codec even if H.264 decoder only advertises byte-stream profile.
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez, commit-queue, eocanha, eric.carlson, jer.noble, jonlee, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Charlie Turner
Reported 2017-09-27 10:51:07 PDT
Try to play AVC codec even if H.264 decoder only advertises byte-stream profile.
Attachments
Patch (2.63 KB, patch)
2017-09-28 15:06 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.63 KB, patch)
2017-10-02 03:49 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2017-09-28 10:08:00 PDT
Can you discuss a little bit more your use case?
Charlie Turner
Comment 2 2017-09-28 14:58:52 PDT
It seems I've accidentally pulled the trigger on uploading this patch before it's ready. This is specific to GTK/WPE, sorry for the false alarm.
Charlie Turner
Comment 3 2017-09-28 15:06:21 PDT
Created attachment 322123 [details] Patch
Enrique Ocaña
Comment 4 2017-09-29 02:58:06 PDT
Looks good. I'm assuming that playbin properly places an h264parse element to convert from avc to byte-stream, right?
Charlie Turner
Comment 5 2017-09-29 03:19:15 PDT
> I'm assuming that playbin properly places an h264parse element to convert from avc to byte-stream, right? That's correct. The GstH264Parse element will be inserted by playbin when the H.264 decoder only advertises byte-stream. While this isn't the case for a typical desktop GStreamer using libav, whose decoder supports both AVC and byte-stream. But on embedded systems like the Pi, the OpenMAX decoder only advertises byte-stream, and in this case the playbin will automatically convert it for us. That's why we didn't notice any issues on desktop, because the filter did succeed, it's just not necessary with the ability of our pipeline to dynamically convert to bytestream if needed.
Carlos Alberto Lopez Perez
Comment 6 2017-09-29 10:57:05 PDT
Comment on attachment 322123 [details] Patch r=me if this looks good for Enrique :)
Charlie Turner
Comment 7 2017-10-02 03:49:25 PDT
Created attachment 322369 [details] Patch for landing
WebKit Commit Bot
Comment 8 2017-10-02 06:17:45 PDT
Comment on attachment 322369 [details] Patch for landing Clearing flags on attachment: 322369 Committed r222707: <http://trac.webkit.org/changeset/222707>
WebKit Commit Bot
Comment 9 2017-10-02 06:17:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.