Bug 180069

Summary: REGRESSION (r225199): webkitpy: PlatformInfo raises AssertionError "assert self.os_version is not None" in Cygwin since Bug 179621
Product: WebKit Reporter: Fujii Hironori <fujii>
Component: Tools / TestsAssignee: Fujii Hironori <fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ews-watchlist, glenn, lforschler, pvollan, webkit-bug-importer
Priority: P1 Keywords: InRadar, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 179621    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2017-11-28 00:32:12 PST
> $ ./Tools/Scripts/check-webkit-style > Traceback (most recent call last): > File "./Tools/Scripts/check-webkit-style", line 44, in <module> > from webkitpy.style.main import CheckWebKitStyle > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/main.py", line 27, in <module> > import webkitpy.style.checker as checker > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/checker.py", line 54, in <module> > from checkers.test_expectations import TestExpectationsChecker > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 46, in <module> > class TestExpectationsChecker(object): > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 124, in TestExpectationsChecker > def lint_test_expectations(files, configuration, cwd, increment_error_count=lambda: 0, line_numbers=None, host=Host()): > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/host.py", line 48, in __init__ > SystemHost.__init__(self) > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/system/systemhost.py", line 40, in __init__ > self.user = user.User() > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/system/user.py", line 61, in __init__ > self._platforminfo = platforminfo or PlatformInfo(sys, platform, Executive()) > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/system/platforminfo.py", line 74, in __init__ > assert self.os_version is not None > AssertionError >
Attachments
Patch (1.73 KB, patch)
2017-11-28 00:42 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2017-11-28 00:36:53 PST
The output of ver command looks like this: > C:\>ver > > Microsoft Windows [Version 10.0.16299.64] >
Fujii Hironori
Comment 2 2017-11-28 00:42:37 PST
Created attachment 327735 [details] Patch
WebKit Commit Bot
Comment 3 2017-11-28 06:43:34 PST
Comment on attachment 327735 [details] Patch Clearing flags on attachment: 327735 Committed r225215: <https://trac.webkit.org/changeset/225215>
WebKit Commit Bot
Comment 4 2017-11-28 06:43:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-11-28 06:45:23 PST
<rdar://problem/35721810>
Note You need to log in before you can comment on or make changes to this bug.