Bug 189183

Summary: slotchange-event-bubbling.html fails in Chrome & Firefox
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, koivisto, lforschler, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189144    
Attachments:
Description Flags
Fixes the test cdumez: review+

Ryosuke Niwa
Reported 2018-08-30 21:38:37 PDT
There is a bug in slotchange-event-bubbling.html such that it fails in Chrome & Firefox. We would start failing this test as well once the bug 189144 is fixed.
Attachments
Fixes the test (6.89 KB, patch)
2018-08-30 21:43 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-08-30 21:43:03 PDT
Created attachment 348600 [details] Fixes the test
Chris Dumez
Comment 2 2018-08-31 13:32:56 PDT
Comment on attachment 348600 [details] Fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=348600&action=review > LayoutTests/ChangeLog:8 > + slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes. Typo: assinged > LayoutTests/ChangeLog:10 > + Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask Typo: implements -> implement / fails -> fail > LayoutTests/ChangeLog:13 > + Fixed the test by manually waiting for the current microtask queue is emptied after constructing is emptied -> to be emptied?
Ryosuke Niwa
Comment 3 2018-08-31 13:39:25 PDT
(In reply to Chris Dumez from comment #2) > Comment on attachment 348600 [details] > Fixes the test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348600&action=review > > > LayoutTests/ChangeLog:8 > > + slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes. > > Typo: assinged Fixed. > > LayoutTests/ChangeLog:10 > > + Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask > > Typo: implements -> implement / fails -> fail Fixed. > > LayoutTests/ChangeLog:13 > > + Fixed the test by manually waiting for the current microtask queue is emptied after constructing > > is emptied -> to be emptied? Fixed.
Ryosuke Niwa
Comment 4 2018-08-31 13:41:59 PDT
Committed r235568: <https://trac.webkit.org/changeset/235568>
Radar WebKit Bug Importer
Comment 5 2018-08-31 13:42:17 PDT
<rdar://problem/43953435>
Note You need to log in before you can comment on or make changes to this bug.