Bug 191310

Summary: Add onslotchange on ShadowRoot, SVG, and HTML elements
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annevk, cdumez, changseok, dbarton, d, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, kangil.han, kondapallykalyan, sam, soniasingla.1812, tetsuharu.ohzeki, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Ryosuke Niwa
Reported 2018-11-06 10:15:48 PST
See https://github.com/whatwg/html/issues/3487
Attachments
Patch (63.95 KB, patch)
2020-10-02 08:16 PDT, Tetsuharu Ohzeki [UTC+9] 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (64.71 KB, patch)
2020-10-02 10:15 PDT, Tetsuharu Ohzeki [UTC+9] 		no flags
DetailsFormatted DiffDiff
Patch (63.95 KB, patch)
2020-10-02 10:49 PDT, Tetsuharu Ohzeki [UTC+9] 		no flags
DetailsFormatted DiffDiff
Patch (64.34 KB, patch)
2020-10-03 08:35 PDT, Tetsuharu Ohzeki [UTC+9] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Domenic Denicola
Comment 1 2019-09-19 20:50:02 PDT
Spec pull request: https://github.com/whatwg/html/pull/4129 . It looks like we ended up using GlobalEventHandlers. We are also considering adding it to ShadowRoot, but there's no spec PR for that yet.
Anne van Kesteren
Comment 2 2019-09-23 02:04:22 PDT
There is now and I suspect we'll merge it once an editorial matter is resolved: https://github.com/whatwg/dom/pull/785.
Ryosuke Niwa
Comment 3 2019-10-08 19:29:24 PDT
https://github.com/whatwg/html/pull/4129
Tetsuharu Ohzeki [UTC+9]
Comment 4 2020-10-02 08:16:42 PDT
Created attachment 410325 [details] Patch
Tetsuharu Ohzeki [UTC+9]
Comment 5 2020-10-02 10:15:38 PDT
Created attachment 410334 [details] Patch
Tetsuharu Ohzeki [UTC+9]
Comment 6 2020-10-02 10:49:09 PDT
Created attachment 410337 [details] Patch
Ryosuke Niwa
Comment 7 2020-10-02 19:18:49 PDT
Comment on attachment 410337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410337&action=review Looks okay to me but your change logs need some work. > Source/WebCore/ChangeLog:7 > + Could you add a description here? > Source/WebCore/ChangeLog:9 > + Tests: > + imported/w3c/web-platform-tests/dom/idlharness.window.html: This isn't right. The first test name should appear after "Tests:" followed by a single space, and the subsequent lines should appear aligned to that line: e.g. Tests: imported/w3c/web-platform-tests/dom/idlharness.window.html imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events.html ... > LayoutTests/ChangeLog:7 > + Say that you've rebaselined tests now that more test cases are passing. > LayoutTests/imported/w3c/ChangeLog:7 > + Ditto.
Tetsuharu Ohzeki [UTC+9]
Comment 8 2020-10-03 08:33:28 PDT
Comment on attachment 410337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410337&action=review >> Source/WebCore/ChangeLog:7 >> + > > Could you add a description here? I thought this was self-obvious. I'll add a description.
Tetsuharu Ohzeki [UTC+9]
Comment 9 2020-10-03 08:35:13 PDT
Created attachment 410424 [details] Patch
EWS
Comment 10 2020-10-03 17:34:58 PDT
Committed r267939: <https://trac.webkit.org/changeset/267939> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410424 [details].
Radar WebKit Bug Importer
Comment 11 2020-10-03 17:35:29 PDT
<rdar://problem/69922171>
Note You need to log in before you can comment on or make changes to this bug.