Bug 201049

Summary: [Subpixel layout] reddit.com comments are slightly scrollable
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: NEW    
Severity: Normal CC: bfulgham, ews-watchlist, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
simon.fraser: review+
Archive of layout-test-results from ews215 for win-future none

alan
Reported 2019-08-22 13:08:38 PDT
<rdar://problem/49951104>
Attachments
Patch (6.91 KB, patch)
2019-08-22 13:19 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (6.89 KB, patch)
2019-08-22 13:23 PDT, alan 		simon.fraser: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews215 for win-future (13.66 MB, application/zip)
2019-08-22 14:59 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2019-08-22 13:19:13 PDT
Created attachment 377037 [details] Patch
alan
Comment 2 2019-08-22 13:23:46 PDT
Created attachment 377038 [details] Patch
Simon Fraser (smfr)
Comment 3 2019-08-22 13:38:11 PDT
Comment on attachment 377038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377038&action=review > Source/WebCore/ChangeLog:9 > + Since RootLines are forced to be on integral positions, we need to ensure that the block container's height is adjusted accordingly (to always enclose the lines in the case of LayoutUnit -> int conversion). Need more explanation here.
EWS Watchlist
Comment 4 2019-08-22 14:59:15 PDT
Comment on attachment 377038 [details] Patch Attachment 377038 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12957981 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 5 2019-08-22 14:59:17 PDT
Created attachment 377057 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
alan
Comment 6 2019-08-22 14:59:54 PDT
(In reply to Build Bot from comment #5) > Created attachment 377057 [details] > Archive of layout-test-results from ews215 for win-future > > The attached test failures were seen while running run-webkit-tests on the > win-ews. > Bot: ews215 Port: win-future Platform: > CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit ofc.
Note You need to log in before you can comment on or make changes to this bug.