Bug 202497

Summary: Resync WPT shadow DOM tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, koivisto, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 166484    
Attachments:
Description Flags
Resynced tests
none
Patch for landing none

Ryosuke Niwa
Reported 2019-10-02 15:30:47 PDT
Update the tests.
Attachments
Resynced tests (84.14 KB, patch)
2019-10-02 15:33 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (86.99 KB, patch)
2019-10-02 21:28 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-10-02 15:33:32 PDT
Created attachment 380067 [details] Resynced tests
Ryosuke Niwa
Comment 2 2019-10-02 15:35:51 PDT
Note: this patch takes https://github.com/web-platform-tests/wpt/pull/19479 into account.
Sam Weinig
Comment 3 2019-10-02 15:37:19 PDT
Comment on attachment 380067 [details] Resynced tests rs=me
Ryosuke Niwa
Comment 4 2019-10-02 15:39:42 PDT
Thanks!
Ryosuke Niwa
Comment 5 2019-10-02 21:28:36 PDT
Created attachment 380079 [details] Patch for landing
Ryosuke Niwa
Comment 6 2019-10-02 21:29:29 PDT
Comment on attachment 380079 [details] Patch for landing Wait for EWS.
Ryosuke Niwa
Comment 7 2019-10-02 21:30:29 PDT
Apparently sending tab key via UIController doesn't move the focus forward on iOS. There are tests with form controls where it seems to be working so it's rather mysterious. It probably needs to be investigated in another bug as there are other tests that are currently skipped on iOS for similar reasons.
Ryosuke Niwa
Comment 8 2019-10-03 16:53:44 PDT
Hm... I can't reproduce the test failure of imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002.html on macOS Mojave. Maybe it's high Sierra only?? That's weird though...
Ryosuke Niwa
Comment 9 2019-10-03 16:56:07 PDT
This is so frustrating. I've been trying to land this patch for the last three days :(
Ryosuke Niwa
Comment 10 2019-10-03 19:00:15 PDT
Committed r250696: <https://trac.webkit.org/changeset/250696>
Radar WebKit Bug Importer
Comment 11 2019-10-03 19:01:17 PDT
<rdar://problem/55970683>
Note You need to log in before you can comment on or make changes to this bug.