Bug 211082

Summary: Rename CSSAnimationController accessors from animation() to legacyAnimation()
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, darin, dino, dstockwell, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, gyuyoung.kim, kangil.han, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Antoine Quint
Reported 2020-04-27 09:48:14 PDT
Rename CSSAnimationController accessors from animation() to legacyAnimation()
Attachments
Patch (32.01 KB, patch)
2020-04-27 09:50 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (34.90 KB, patch)
2020-04-27 10:32 PDT, Antoine Quint 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-04-27 09:50:24 PDT
Created attachment 397692 [details] Patch
Antoine Quint
Comment 2 2020-04-27 10:32:24 PDT
Created attachment 397697 [details] Patch
Antoine Quint
Comment 3 2020-04-27 13:47:26 PDT
Committed r260774: <https://trac.webkit.org/changeset/260774>
Radar WebKit Bug Importer
Comment 4 2020-04-27 13:48:18 PDT
<rdar://problem/62467071>
Darin Adler
Comment 5 2020-05-09 16:55:16 PDT
Comment on attachment 397697 [details] Patch Will we ever be deleting this, or will it be around indefinitely with the name "legacyAnimation"?
Antoine Quint
Comment 6 2020-05-10 02:00:34 PDT
(In reply to Darin Adler from comment #5) > Comment on attachment 397697 [details] > Patch > > Will we ever be deleting this, or will it be around indefinitely with the > name "legacyAnimation"? We will absolutely be deleting this at the first opportunity. We are only keeping this code around for the ability to A/B test regressions on ToT for a while longer, but this is a few months at best. I am eagerly awaiting the opportunity to rip out CSSAnimationController and all related code.
Note You need to log in before you can comment on or make changes to this bug.