Bug 214925

Summary: Make sure playback state constants remain on OscillatorNode for backward compatibility
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214902
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-07-29 10:53:30 PDT
Make sure playback state constants remain on OscillatorNode for backward compatibility, while we keep supporting the prefixed Web Audio API.
Attachments
Patch (6.78 KB, patch)
2020-07-29 10:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.86 KB, patch)
2020-07-29 10:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-07-29 10:54:58 PDT
Created attachment 405474 [details] Patch
Eric Carlson
Comment 2 2020-07-29 10:57:05 PDT
Comment on attachment 405474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405474&action=review > Source/WebCore/Modules/webaudio/OscillatorNode.idl:41 > + // Legacy Playback state constants kept for backward compatibility with the prefixed API. You may want to add a comment that these will be removed at some point.
Chris Dumez
Comment 3 2020-07-29 10:59:55 PDT
Created attachment 405475 [details] Patch
EWS
Comment 4 2020-07-29 12:12:51 PDT
Committed r265050: <https://trac.webkit.org/changeset/265050> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405475 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-29 12:13:18 PDT
<rdar://problem/66285511>
Note You need to log in before you can comment on or make changes to this bug.