Bug 216984

Summary: Simplify SVGTests.hasExtension idl
Product: WebKit Reporter: Rob Buis <rbuis>
Component: SVGAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, esprehn+autocc, ews-watchlist, fmalita, gyuyoung.kim, kondapallykalyan, pdr, sabouhallawa, sam, schenney, sergio, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198652
https://bugs.webkit.org/show_bug.cgi?id=204125
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2020-09-25 12:13:01 PDT
Simplify SVGTests.hasExtension idl by removing optional and default parameter. Skipping the parameter will now result in the parameter being a null string, which gives the same behaviour as before as the method just checks against non null namespaces. [1] https://www.w3.org/TR/SVG11/types.html#__svg__SVGTests__hasExtension
Attachments
Patch (2.88 KB, patch)
2020-09-25 12:26 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-09-25 12:26:53 PDT
Created attachment 409720 [details] Patch
EWS
Comment 2 2020-09-25 13:19:43 PDT
Committed r267590: <https://trac.webkit.org/changeset/267590> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409720 [details].
Radar WebKit Bug Importer
Comment 3 2020-09-25 13:20:17 PDT
<rdar://problem/69590625>
Said Abou-Hallawa
Comment 4 2020-09-25 13:47:30 PDT
SVGTests.hasExtension and SVGTests.requiredFeatures were removed in SVG2. Specs link: https://www.w3.org/TR/SVG2/types.html#InterfaceSVGTests WebKit bugs to remove hasExtension and requiredFeatures: https://bugs.webkit.org/show_bug.cgi?id=198652 https://bugs.webkit.org/show_bug.cgi?id=204125 Chrome bug to remove requiredFeatures: https://bugzilla.mozilla.org/show_bug.cgi?id=1295404 Chrome bug to remove hasExtension: https://bugs.chromium.org/p/chromium/issues/detail?id=532405
Rob Buis
Comment 5 2020-09-25 14:07:18 PDT
(In reply to Said Abou-Hallawa from comment #4) > SVGTests.hasExtension and SVGTests.requiredFeatures were removed in SVG2. > > Specs link: > https://www.w3.org/TR/SVG2/types.html#InterfaceSVGTests > > WebKit bugs to remove hasExtension and requiredFeatures: > https://bugs.webkit.org/show_bug.cgi?id=198652 > https://bugs.webkit.org/show_bug.cgi?id=204125 > > Chrome bug to remove requiredFeatures: > https://bugzilla.mozilla.org/show_bug.cgi?id=1295404 > > Chrome bug to remove hasExtension: > https://bugs.chromium.org/p/chromium/issues/detail?id=532405 My main motivation is to remove the "Using "undefined" as default parameter value is wrong" FIXMEs, I'll continue to work on that. Is there anything left before removing these two methods? If not, I could work on that or review your patches.
Note You need to log in before you can comment on or make changes to this bug.