Bug 234373

Summary: [css-values-4] logical `*vi`(inline) and `*vb` (block) viewport units should be based on the current element's `writing-mode`
Product: WebKit Reporter: Devin Rousso <hi>
Component: CSSAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bramus, esprehn+autocc, ews-watchlist, glenn, gsnedders, gyuyoung.kim, hi, jensimmons, macpherson, menard, ntim, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232895    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2021-12-15 17:39:47 PST
from https://github.com/w3c/csswg-drafts/issues/6873#issuecomment-995093243 > RESOLVED: Writing-mode sensitive viewport units (and analogous units) use the writing mode of the element they're used on.
Attachments
Patch (59.81 KB, patch)
2021-12-15 17:47 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-12-15 17:47:24 PST
Created attachment 447303 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-12-15 20:55:23 PST
Comment on attachment 447303 [details] Patch WPT?
Radar WebKit Bug Importer
Comment 3 2021-12-22 17:40:16 PST
<rdar://problem/86832561>
Tim Nguyen (:ntim)
Comment 4 2022-02-27 00:20:15 PST
Comment on attachment 447303 [details] Patch What Simon said :)
Tim Nguyen (:ntim)
Comment 5 2022-02-27 00:20:47 PST
Also stylebot doesn't look happy
Sam Sneddon [:gsnedders]
Comment 6 2022-04-18 18:24:41 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 447303 [details] > Patch > > WPT? /css/css-values/viewport-units-writing-mode.html covers this now (though didn't exist when you wrote that comment!)
Tim Nguyen (:ntim)
Comment 7 2022-04-28 08:48:02 PDT
(In reply to Sam Sneddon [:gsnedders] from comment #6) > (In reply to Simon Fraser (smfr) from comment #2) > > Comment on attachment 447303 [details] > > Patch > > > > WPT? > > /css/css-values/viewport-units-writing-mode.html covers this now (though > didn't exist when you wrote that comment!) Let's import them! :)
Devin Rousso
Comment 8 2022-05-20 15:02:55 PDT
Pull request: https://github.com/WebKit/WebKit/pull/863
EWS
Comment 9 2022-05-20 22:40:37 PDT
Committed r294609 (250835@main): <https://commits.webkit.org/250835@main> Reviewed commits have been landed. Closing PR #863 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.