Bug 239665
| Summary: | "No new tests (OOPS!)." appears in wrong place in the commit message | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=240701 | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Chris Dumez
"No new tests (OOPS!)." appears in wrong place in the commit message when using the new GIT commit hook:
Start preparing the code base for making the AtomString(const String&) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=239658
Reviewed by NOBODY (OOPS!).
Start preparing the code base for making the AtomString(const String&) constructor explicit.
This helps us find cases where we atomize unnecessarily or not early enough, thus causing
unnecessary String allocations.
* Source/JavaScriptCore/runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeToAtomString const):
* Source/WebKit/WebProcess/Plugins/Plugin.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/DOM/DOMCustomXPathNSResolver.h:
* Source/WebKitLegacy/mac/DOM/DOMCustomXPathNSResolver.mm:
(DOMCustomXPathNSResolver::lookupNamespaceURI):
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(parameterValue):
(WebFrameLoaderClient::createPlugin):
* Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
* Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WTF/wtf/persistence/PersistentCoders.cpp:
(WTF::Persistence::Coder<AtomString>::decode):
* Source/WTF/wtf/text/StringBuilder.h:
(WTF::StringBuilder::toAtomString const):
* Source/WTF/wtf/text/StringConcatenate.h:
(WTF::tryMakeAtomStringFromAdapters):
* Source/WTF/wtf/text/StringView.cpp:
(WTF::convertASCIILowercaseAtom):
No new tests (OOPS!). // WHY IS THIS HERE?
* Source/WebCore/Modules/gamepad/GamepadEvent.idl:
* Source/WebCore/Modules/mediasession/MediaMetadata.cpp:
(WebCore::ArtworkImageLoader::requestImageResource):
* Source/WebCore/Modules/plugins/PluginReplacement.h:
(WebCore::ReplacementPlugin::create const):
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/92537106>
Chris Dumez
This is sooo annoying. I keep missing the ""No new tests (OOPS!)." because it is hidden among the many modified files and then the patch fails to commit :(
Ryan Haddad
*** This bug has been marked as a duplicate of bug 240701 ***
Ryan Haddad
Duped the wrong way, sorry.
Ryan Haddad
*** Bug 240701 has been marked as a duplicate of this bug. ***