Bug 28078

Summary:

WebInspector: Move object properties read / write access into InjectedScript

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, dglazkov, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

32442

Attachments:

Description	Flags
patch	timothy: review-
patch	timothy: review+

Pavel Feldman

Reported 2009-08-07 11:49:51 PDT

Now that styles are edited entirely by means of InjectedScript, it is time to migrate Objects to use the same schema.

Attachments
patch (20.70 KB, patch) 2009-08-07 11:57 PDT, Pavel Feldman	timothy: review-	Details Formatted Diff Diff
patch (26.06 KB, patch) 2009-08-07 13:43 PDT, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2009-08-07 11:57:53 PDT

Created attachment 34309 [details] patch

Timothy Hatcher

Comment 2 2009-08-07 13:01:35 PDT

Comment on attachment 34309 [details] patch > -WebInspector.ObjectPropertiesSection = function(object, title, subtitle, emptyPlaceholder, ignoreHasOwnProperty, extraProperties, treeElementConstructor) > +WebInspector.ObjectRef = function(objectId, path, protoDepth) I think this should go into a new file and not ObjectPropertiesSection.js, since it is used in other places and not specific to the ObjectPropertiesSection. I am not too fond of the Ref suffix. Do you like ObjectProxy better? > + this.objectId = objectId; You should add a comment about this, this looks temporary. > + this.path = path || []; > +InjectedScript._objectForId = function(objectId) > +{ > + return objectId; > +} You hould add a comment about this being temporary.

Pavel Feldman

Comment 3 2009-08-07 13:43:23 PDT

Created attachment 34321 [details] patch (In reply to comment #2) > (From update of attachment 34309 [details]) > > > I think this should go into a new file and not ObjectPropertiesSection.js, > since it is used in other places and not specific to the > ObjectPropertiesSection. > Done. > I am not too fond of the Ref suffix. Do you like ObjectProxy better? > Done. > > You should add a comment about this, this looks temporary. > Done (added TODO). > > You hould add a comment about this being temporary. Done (added TODO).

Timothy Hatcher

Comment 4 2009-08-07 13:50:35 PDT

Comment on attachment 34321 [details] patch > diff --git a/WebCore/inspector/front-end/ObjectProxy.js b/WebCore/inspector/front-end/ObjectProxy.js > \ No newline at end of file Add a newline.

Dimitri Glazkov (Google)

Comment 5 2009-08-07 14:02:57 PDT

Pfeldman wants to land it himself.

Pavel Feldman

Comment 6 2009-08-10 03:03:34 PDT

M WebCore/ChangeLog M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/DOMAgent.js M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/ObjectPropertiesSection.js A WebCore/inspector/front-end/ObjectProxy.js M WebCore/inspector/front-end/PropertiesSidebarPane.js M WebCore/inspector/front-end/ScopeChainSidebarPane.js M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.html Committed r46972

David Kilzer (:ddkilzer)

Comment 7 2010-03-28 04:16:16 PDT

This fix caused Bug 32442.

Note You need to log in before you can comment on or make changes to this bug.