Bug 33229

Summary: Don't use renderer for Resources in SVGRenderBase::prepareToRenderSVGContent
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 68469, 26389    
Attachments:
Description Flags
Don't use Renderer for SVGResource calculations zimmermann: review-

Dirk Schulze
Reported 2010-01-05 14:09:03 PST
Don't use renderer for Resources in SVGRenderBase::prepareToRenderSVGContent. Some Renderer don't provide correct boundingBoxes or don't inherit from SVGRenderBase. This can cause an ASSERT in RenderObject.
Attachments
Don't use Renderer for SVGResource calculations (47.49 KB, patch)
2010-01-05 14:24 PST, Dirk Schulze 		zimmermann: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2010-01-05 14:24:04 PST
Created attachment 45931 [details] Don't use Renderer for SVGResource calculations Don't use Renderer for SVGResource calculations.
WebKit Review Bot
Comment 2 2010-01-05 14:28:20 PST
style-queue ran check-webkit-style on attachment 45931 [details] without any errors.
Nikolas Zimmermann
Comment 3 2010-01-06 19:09:13 PST
Comment on attachment 45931 [details] Don't use Renderer for SVGResource calculations Postponed, as discussed with Dirk. Let's fix RenderSVGInline, and pass around renderers.
Dirk Schulze
Comment 4 2010-04-21 13:32:02 PDT
The bounding box / repaint rect problems are fixed. Closing this bug now.
Note You need to log in before you can comment on or make changes to this bug.