Bug 35944

Summary:

Add an appengine app to host chromium layout test results

Product:

WebKit

Reporter:

Victor Wang <victorw>

Component:

Tools / Tests

Assignee:

Victor Wang <victorw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, dglazkov, eric, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Proposed Patch	none
Fixed a CR in proposed patch	abarth: review-
Proposed patch	none

Victor Wang

Reported 2010-03-09 14:18:40 PST

Add an appengine app to host layout test results (JSON) for chromium flakiness dashboard. The app could be used to host other test result files if needed.

Attachments
Proposed Patch (24.64 KB, patch) 2010-03-09 14:24 PST, Victor Wang	no flags	Details Formatted Diff Diff
Fixed a CR in proposed patch (24.62 KB, patch) 2010-03-09 14:39 PST, Victor Wang	abarth: review-	Details Formatted Diff Diff
Proposed patch (27.30 KB, patch) 2010-03-12 14:15 PST, Victor Wang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Victor Wang

Comment 1 2010-03-09 14:24:26 PST

Created attachment 50348 [details] Proposed Patch

WebKit Review Bot

Comment 2 2010-03-09 14:28:17 PST

Attachment 50348 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/Scripts/webkitpy/test_result_server/index.yaml:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 30 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Victor Wang

Comment 3 2010-03-09 14:39:42 PST

Created attachment 50351 [details] Fixed a CR in proposed patch

Adam Barth

Comment 4 2010-03-12 08:49:53 PST

Comment on attachment 50351 [details] Fixed a CR in proposed patch This should go in a subdirectory of WebKitTools, analogous to QueueStatusServer, which is another of our AppEngine apps. I'm not sure we want svn:executable or svn:eol-style set on these files. + class DeleteFile This app looks wide open for anonymous folks on the interest to screw with out datastore. Do we care? Do we want some CSS to make this pretty? We can do that in another patch.

Victor Wang

Comment 5 2010-03-12 14:15:45 PST

Created attachment 50632 [details] Proposed patch A couple of updates in new patch: -. moved the appengine to WebKitTool -. added CSS -. removed svn:executable and svn:eol-style -. added test type support -. more blobstore upload redirect handling. Eventually, we will add code to limit users who could update these files, for now, I would like to get a version in and start testing it.

Adam Barth

Comment 6 2010-03-13 01:48:01 PST

Comment on attachment 50632 [details] Proposed patch Okiedokes. Theoretically we're supposed to keep our python to 80 cols, but we probably won't be able to enforce that until we get our automatic pep8 stye checker.

WebKit Commit Bot

Comment 7 2010-03-13 02:45:05 PST

Comment on attachment 50632 [details] Proposed patch Clearing flags on attachment: 50632 Committed r55960: <http://trac.webkit.org/changeset/55960>

WebKit Commit Bot

Comment 8 2010-03-13 02:45:11 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.