Bug 50456

Summary: Remove one row/column of renderers
Product: WebKit Reporter: Alex Bredariol Grilo <abgrilo>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, eric, jprvita, kenneth, kling, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on: 50023    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Alex Bredariol Grilo
Reported 2010-12-03 05:52:02 PST
Remove one row/column of renderers
Attachments
Patch (9.82 KB, patch)
2010-12-03 05:55 PST, Alex Bredariol Grilo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Bredariol Grilo
Comment 1 2010-12-03 05:55:20 PST
Created attachment 75493 [details] Patch
Eric Seidel (no email)
Comment 2 2010-12-13 00:23:57 PST
Who should review this? It's not at all clear to me how to evaluate this patch. I could just rubber-stamp it, but I don't really know who is in charge of the EFL side of things.
Antonio Gomes
Comment 3 2010-12-13 07:30:15 PST
Comment on attachment 75493 [details] Patch Could other guys who know the EFL backing store code review this too?
Lucas De Marchi
Comment 4 2010-12-13 07:53:28 PST
Comment on attachment 75493 [details] Patch LGTM. Eric / Antonio, could you rubber stamp it?
Rafael Antognolli
Comment 5 2010-12-13 08:26:52 PST
Hello Eric and Antonio, Lucas De Marchi, Leandro Pereira and me are currently making informal reviews on the EFL port, since we are also EFL developers and are working on it. But I forgot to make a review on this patch because I had already internally reviewed it for Alex. Anyway, Lucas already said enough.
Rafael Antognolli
Comment 6 2010-12-13 08:27:56 PST
Please also notice that this patch depends on bug 50023.
Andreas Kling
Comment 7 2010-12-13 08:30:28 PST
Comment on attachment 75493 [details] Patch *handwave*
WebKit Review Bot
Comment 8 2010-12-13 09:55:23 PST
The commit-queue encountered the following flaky tests while processing attachment 75493 [details]: inspector/syntax-highlight-css.html bug 50930 (authors: keishi@webkit.org, pfeldman@chromium.org, and yurys@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 9 2010-12-13 09:57:02 PST
Comment on attachment 75493 [details] Patch Clearing flags on attachment: 75493 Committed r73924: <http://trac.webkit.org/changeset/73924>
WebKit Review Bot
Comment 10 2010-12-13 09:57:08 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 11 2010-12-13 12:38:19 PST
The commit-queue encountered the following flaky tests while processing attachment 75493 [details]: animations/combo-transform-translate+scale.html bug 50958 (authors: cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com) animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.