Bug 51985

Summary: [Qt][GTK] Use GraphicsContext::hasShadow() in port-specific code
Product: WebKit Reporter: Helder Correia <helder>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ariya.hidayat, commit-queue, eric, mdelaney7, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Helder Correia
Reported 2011-01-06 01:14:39 PST
r75139 introduced GraphicsContext::hasShadow(). This can now simplify and unify some code in the Qt and GTK ports.
Attachments
Patch (7.16 KB, patch)
2011-01-06 01:17 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2011-01-06 01:17:45 PST
Created attachment 78102 [details] Patch
WebKit Commit Bot
Comment 2 2011-01-06 02:50:06 PST
Comment on attachment 78102 [details] Patch Clearing flags on attachment: 78102 Committed r75148: <http://trac.webkit.org/changeset/75148>
WebKit Commit Bot
Comment 3 2011-01-06 02:50:12 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 4 2011-01-06 04:00:41 PST
The commit-queue encountered the following flaky tests while processing attachment 78102 [details]: http/tests/xmlhttprequest/re-login.html bug 51987 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 5 2011-01-06 04:07:26 PST
http://trac.webkit.org/changeset/75148 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.