Bug 58813

Summary: remove tests from test_expectations.txt, as they now pass
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Mike Reed
Reported 2011-04-18 12:46:50 PDT
remove tests from test_expectations.txt, as they now pass
Attachments
Patch (1.50 KB, patch)
2011-04-18 12:47 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-04-18 12:47:36 PDT
Created attachment 90075 [details] Patch
Mike Reed
Comment 2 2011-04-18 12:48:36 PDT
fast/canvas/canvas-strokeRect-alpha-shadow.html fast/canvas/canvas-strokePath-alpha-shadow.html these now pass
Kenneth Russell
Comment 3 2011-04-18 13:04:59 PDT
Comment on attachment 90075 [details] Patch Looks good.
WebKit Commit Bot
Comment 4 2011-04-18 14:45:39 PDT
Comment on attachment 90075 [details] Patch Rejecting attachment 90075 [details] from commit-queue. Failed to run "[u'zip', u'-r', u'../commit-queue-logs/58813-layout-test-results-1.zip', u'/tmp/layout-test-resul..." exit_code: 12 zip warning: name not matched: /tmp/layout-test-results zip error: Nothing to do! (try: zip -r ../commit-queue-logs/58813-layout-test-results-1.zip . -i /tmp/layout-test-results) Full output: http://queues.webkit.org/results/8470109
Kenneth Russell
Comment 5 2011-04-18 15:12:55 PDT
Comment on attachment 90075 [details] Patch Not sure what went wrong with the last attempt in the commit queue. Trying again.
WebKit Commit Bot
Comment 6 2011-04-18 20:39:48 PDT
Comment on attachment 90075 [details] Patch Clearing flags on attachment: 90075 Committed r84218: <http://trac.webkit.org/changeset/84218>
WebKit Commit Bot
Comment 7 2011-04-18 20:39:52 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 8 2011-04-18 22:06:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 90075 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/xmlhttprequest/cookies.html bug 51976 (authors: ap@webkit.org and eric@webkit.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.