Bug 59900

Summary: StringImpl::endsWith has some insane code
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric, levin, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from cr-jail-7
none
Patch none

Adam Barth
Reported 2011-05-01 16:11:05 PDT
StringImpl::endsWith has some insane (and wrong) code
Attachments
Patch (1.83 KB, patch)
2011-05-01 16:13 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from cr-jail-7 (40.58 KB, application/zip)
2011-05-01 21:32 PDT, WebKit Commit Bot 		no flags
Details
Patch (1.58 KB, patch)
2011-05-02 01:55 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-05-01 16:13:03 PDT
Created attachment 91855 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-01 16:15:13 PDT
Comment on attachment 91855 [details] Patch How do we test this?
Adam Barth
Comment 3 2011-05-01 16:25:32 PDT
@dave_levin: Is the WTF unit testing framework ready for use?
Sam Weinig
Comment 4 2011-05-01 17:47:18 PDT
(In reply to comment #3) > @dave_levin: Is the WTF unit testing framework ready for use? The existing one in Tools/TestWebKitAPI works. It will be transitioned to GTest at somepoint, but that should not stop people from using it now.
Adam Barth
Comment 5 2011-05-01 17:50:28 PDT
WebKitAPITest != TestWebKitAPI :)
Sam Weinig
Comment 6 2011-05-01 17:53:07 PDT
(In reply to comment #5) > WebKitAPITest != TestWebKitAPI :) Adam Roben and I like to confuse and befuddle.
Adam Barth
Comment 7 2011-05-01 18:15:36 PDT
Sadly, that test harness can't handing anything the depends on String because the include paths are all screwed up.
Adam Barth
Comment 8 2011-05-01 20:02:52 PDT
Comment on attachment 91855 [details] Patch I'm just going to land this patch. It doesn't seem worthwhile to teach this test harness to include these files if we're just going to change the harness soon.
WebKit Commit Bot
Comment 9 2011-05-01 21:32:36 PDT
Comment on attachment 91855 [details] Patch Rejecting attachment 91855 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build-..." exit_code: 2 Last 500 characters of output: led .. animations/change-keyframes-name.html -> failed . animations/change-keyframes.html -> failed . animations/change-one-anim.html -> failed . animations/combo-transform-rotate+scale.html -> failed . animations/combo-transform-translate+scale.html -> failed .. animations/dynamic-stylesheet-loading.html -> failed Exiting early after 10 failures. 111 tests run. 38.93s total testing time 101 test cases (90%) succeeded 10 test cases (9%) had incorrect layout 2 test cases (1%) had stderr output Full output: http://queues.webkit.org/results/8529503
WebKit Commit Bot
Comment 10 2011-05-01 21:32:40 PDT
Created attachment 91878 [details] Archive of layout-test-results from cr-jail-7 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.7
Alexey Proskuryakov
Comment 11 2011-05-01 23:16:55 PDT
Comment on attachment 91855 [details] Patch + return (caseSensitive ? find(matchString, start) == start : findIgnoringCase(matchString, start)) == start; This is not right.
Adam Barth
Comment 12 2011-05-01 23:27:54 PDT
> This is not right. Apparently. :)
Adam Barth
Comment 13 2011-05-02 01:55:51 PDT
Created attachment 91898 [details] Patch
WebKit Commit Bot
Comment 14 2011-05-02 09:51:47 PDT
The commit-queue encountered the following flaky tests while processing attachment 91898 [details]: http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html bug 59940 The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 15 2011-05-02 09:52:56 PDT
Comment on attachment 91898 [details] Patch Clearing flags on attachment: 91898 Committed r85482: <http://trac.webkit.org/changeset/85482>
WebKit Commit Bot
Comment 16 2011-05-02 09:53:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.