Bug 61297

Summary: fix rel=prerender target types
Product: WebKit Reporter: Gavin Peters <gavinp>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, commit-queue, gavinp, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gavin Peters
Reported 2011-05-23 12:23:11 PDT
fix rel=prerender target types
Attachments
Patch (2.88 KB, patch)
2011-05-23 12:26 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Patch (3.31 KB, patch)
2011-05-23 12:35 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Peters
Comment 1 2011-05-23 12:26:32 PDT
Created attachment 94459 [details] Patch
Gavin Peters
Comment 2 2011-05-23 12:28:16 PDT
Comment on attachment 94459 [details] Patch I have learned a valuable lesson; always test the chrome side of a webkit patch that has chrome implication before uploading to WebKit.
Adam Barth
Comment 3 2011-05-23 12:30:10 PDT
Comment on attachment 94459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94459&action=review > Source/WebCore/ChangeLog:10 > + The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079 > + didn't properly map the target type, and didn't carry the target > + types through to chromium properly. Fixed. Bad indent. > Source/WebCore/ChangeLog:12 > + No new tests. How come?
WebKit Review Bot
Comment 4 2011-05-23 12:30:39 PDT
Attachment 94459 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebKit/chromium/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebKit/chromium/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Peters
Comment 5 2011-05-23 12:35:54 PDT
Created attachment 94463 [details] Patch
Gavin Peters
Comment 6 2011-05-23 12:36:19 PDT
Comment on attachment 94463 [details] Patch tabsbegone, explanation about testing.
WebKit Commit Bot
Comment 7 2011-05-23 16:50:32 PDT
Comment on attachment 94463 [details] Patch Clearing flags on attachment: 94463 Committed r87106: <http://trac.webkit.org/changeset/87106>
WebKit Commit Bot
Comment 8 2011-05-23 16:50:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.