Bug 64092

Summary: REGRESSION(90419) NRWT's httpd locking is broken for --child-processes=1
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, kkristof, ojan, ossy, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Bug Depends on:    
Bug Blocks: 34984, 63116    
Attachments:
Description Flags
Patch none

Andras Becsi
Reported 2011-07-07 08:30:14 PDT
ORWT's httpd locking and scheduling mechanism was implemented to be able to run multiple run-webkit-tests sessions besides each other without interfering, so the the tests needing httpd should mutually exclude each other. Since http://trac.webkit.org/changeset/90419 this mechanism is broken when using --child-processes=1 in two ways: 1) The httpd is started without using the checking mechanism implemented in http://trac.webkit.org/changeset/89414 and the script is crashing when there is no httpd present. 2) The httpd locks are acquired even if not running any http or websocket tests, so one testing session entirely blocks another.
Attachments
Patch (3.85 KB, patch)
2011-07-07 19:18 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-07-07 10:13:05 PDT
Oh? Do we need to turn off NRWT for Qt for the meanwhile?
Dirk Pranke
Comment 2 2011-07-07 10:17:02 PDT
Hm. Neither of these things should be true. There was a bug introduced yesterday on chromium windows where we weren't checking for the http server properly, but the rest of this stuff should be working. I will investigate further.
Dirk Pranke
Comment 3 2011-07-07 19:18:43 PDT
Created attachment 100065 [details] Patch
Dirk Pranke
Comment 4 2011-07-07 19:19:06 PDT
Yup, I definitely broke it. This patch should fix things.
WebKit Review Bot
Comment 5 2011-07-08 12:21:55 PDT
Comment on attachment 100065 [details] Patch Clearing flags on attachment: 100065 Committed r90651: <http://trac.webkit.org/changeset/90651>
WebKit Review Bot
Comment 6 2011-07-08 12:22:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.