Bug 83464

Summary: [CSS Regions]Add helper class for flow threads info in RenderView
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihnea Ovidenie
Reported 2012-04-09 05:30:39 PDT
David Hyatt comment on https://bugs.webkit.org/show_bug.cgi?id=80134: "This isn't really something you should do for this patch, but going forward I think we might want to pull all the flow thread stuff in RenderView into a helper class."
Attachments
Patch (35.41 KB, patch)
2012-04-09 05:41 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (36.70 KB, patch)
2012-04-11 01:33 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2012-04-09 05:41:15 PDT
Created attachment 136215 [details] Patch
Dave Hyatt
Comment 2 2012-04-10 11:28:20 PDT
Comment on attachment 136215 [details] Patch r=me
WebKit Review Bot
Comment 3 2012-04-10 12:12:28 PDT
Comment on attachment 136215 [details] Patch Rejecting attachment 136215 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: derNamedFlowThread.h patching file Source/WebCore/rendering/RenderObject.cpp Hunk #3 succeeded at 565 (offset -24 lines). Hunk #4 succeeded at 2290 (offset -24 lines). patching file Source/WebCore/rendering/RenderTreeAsText.cpp patching file Source/WebCore/rendering/RenderView.cpp patching file Source/WebCore/rendering/RenderView.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'David Hyatt']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12384339
Mihnea Ovidenie
Comment 4 2012-04-11 01:33:50 PDT
Created attachment 136644 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-04-11 02:41:59 PDT
Comment on attachment 136644 [details] Patch for landing Clearing flags on attachment: 136644 Committed r113842: <http://trac.webkit.org/changeset/113842>
WebKit Review Bot
Comment 6 2012-04-11 02:42:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.